Skip to content

Revert jszip Upgrade #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

Revert jszip Upgrade #748

merged 1 commit into from
Dec 7, 2021

Conversation

miles-grant-ibigroup
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup commented Dec 7, 2021 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR reverses the jszip upgrade that appears to break the e2e tests.
This reverts commit 1b3495a, reversing
changes made to 0717ca0.

@miles-grant-ibigroup
revert: "Merge pull request #738 from ibi-group/dependabot/npm_and_ya…
159e8d0 
…rn/jszip-3.7.0"

This reverts commit 1b3495a, reversing
changes made to 0717ca0.
@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Dec 7, 2021
@miles-grant-ibigroup miles-grant-ibigroup merged commit 783ece9 into dev Dec 7, 2021
@miles-grant-ibigroup miles-grant-ibigroup deleted the revert-jszip-upgrade branch December 7, 2021 14:36
@binh-dam-ibigroup binh-dam-ibigroup mentioned this pull request Jun 22, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

+1 more reviewer

@philip-cline philip-cline philip-cline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miles-grant-ibigroup @binh-dam-ibigroup @philip-cline