-
Notifications
You must be signed in to change notification settings - Fork 89
Handle uncaught error and improve add stop by name #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a refactor suggestion regarding the multiple addIndex - 1
and addIndex - 2
instances.
this._matchesStopAtIndex(addIndex - 2) || | ||
this._matchesStopAtIndex(addIndex - 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would extract addIndex - 2
and addIndex - 1
into const
s with comments.
Codecov Report
@@ Coverage Diff @@
## dev #618 +/- ##
===========================================
- Coverage 43.46% 15.52% -27.95%
===========================================
Files 323 324 +1
Lines 17603 16663 -940
Branches 5368 5072 -296
===========================================
- Hits 7652 2587 -5065
- Misses 8676 12012 +3336
- Partials 1275 2064 +789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Checklist
dev
before they can be merged tomaster
)Description
This PR does a few things:
Style
propsScreenshot 1: Adding a stop by name
Screenshot 2: feedback about pattern stops