Add github actions #360
Add github actions #360
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #360 +/- ##
============================================
- Coverage 26.56% 26.43% -0.14%
+ Complexity 648 642 -6
============================================
Files 178 178
Lines 9188 9188
Branches 1243 1243
============================================
- Hits 2441 2429 -12
- Misses 6508 6518 +10
- Partials 239 241 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -0,0 +1,162 @@ | |||
| name: Java CI | |||
|
|
|||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
We need to run this on the push event in order to generate builds for testing outside of the context of a pull request, right?
There was a problem hiding this comment.
Yes, I believe that's the case.
| - name: Deploy to S3 | ||
| uses: jakejarvis/s3-sync-action@master | ||
| with: | ||
| args: --acl public-read | ||
| env: | ||
| AWS_S3_BUCKET: datatools-builds | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| SOURCE_DIR: 'deploy' No newline at end of file |
There was a problem hiding this comment.
This is a security risk to give AWS credentials to a third party. I would have requested that this be changed if I had given a review.
Checklist
devbefore they can be merged tomaster)Description
Replace Travis CI with GitHub Actions. Note: this temporarily disables e2e to get things working with GitHub actions and avoid slowing other PRs down for now (until e2e can be fully debugged).