Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3740: Fixed resolving ELASTICSEARCH_DSN variable for Platform.sh #112

Merged

Conversation

konradoboza
Copy link
Contributor

JIRA: https://issues.ibexa.co/browse/IBX-3740

For quite some time, Platform.sh relies on ELASTICSEARCH_URL env variable, ref:
https://github.com/platformsh/symfonyflex-bridge/blob/b30d3309a02f770e5aec8db06ce59972253a9d0a/platformsh-flex-env.php#L306. Added fallbacking from ELASTICSEARCH_DSN to ELASTICSEARCH_URL seems to do the trick and saves developers from necessity to set any additional env variables on their Platform.sh instances.

Note:
Performing:

1. bin/console ibexa:elasticsearch:put-index-template --overwrite
2. curl -X DELETE 'http://elasticsearch.internal:9200/_all'
3. bin/console ibexa:reindex

once, might be necessary for the new configuration to be picked up.

@konradoboza konradoboza self-assigned this Mar 22, 2024
@konradoboza konradoboza added Bug Something isn't working Ready for review labels Mar 22, 2024
Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-112

before executing the recipes.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team March 22, 2024 13:25
@konradoboza konradoboza requested a review from a team March 22, 2024 14:14
@mikadamczyk mikadamczyk requested a review from a team March 25, 2024 12:56
@konradoboza konradoboza removed their assignment Mar 25, 2024
@micszo micszo self-assigned this Mar 25, 2024
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Elastic on platform.sh. ES setup works fine now.

QA Approved on Ibexa Commerce 4.5.7-dev.

@micszo micszo removed their assignment Mar 27, 2024
@konradoboza konradoboza merged commit 5cd134c into master Mar 27, 2024
3 checks passed
@konradoboza konradoboza deleted the ibx-3740-missing-env-variable-resolving-for-elasticsearch branch March 27, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants