Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9415: Added support for ContentAwareInterface in ibexa_* Twig functions #467

Merged
merged 9 commits into from
Feb 12, 2025

Conversation

wiewiurdp
Copy link
Contributor

@wiewiurdp wiewiurdp commented Jan 27, 2025

🎫 Issue IBX-9415

Related PRs:

Description:

Added support for ContentAwareInterface objects (e.g. product) to following Twing functions

  • ibexa_render_field
  • ibexa_field_value - core
  • ibexa_field
  • ibexa_field_name
  • ibexa_field_description
  • ibexa_field_is_empty
  • ibexa_has_field
  • ibexa_content_field_identifier_first_filled_image
  • ibexa_content_name
  • ibexa_render_content

For QA:

It needs to be chcked if all theses functions can instead of content as a first argument also work with for example product

Documentation:

Docs for all theses functions should be changed that they are working also with ContentAwareInterfaced objects

@wiewiurdp wiewiurdp requested a review from a team January 27, 2025 13:05
@wiewiurdp wiewiurdp added Doc needed The changes require some documentation Ready for review labels Jan 27, 2025
@ViniTou ViniTou changed the title IBX-9415 Support for ContentAwareInterface in ibexa_* Twig functions added IBX-9415: Support for ContentAwareInterface in ibexa_* Twig functions added Jan 28, 2025
@alongosz alongosz changed the title IBX-9415: Support for ContentAwareInterface in ibexa_* Twig functions added IBX-9415: Added support for ContentAwareInterface in ibexa_* Twig functions Jan 31, 2025
@alongosz alongosz requested a review from a team February 4, 2025 12:21
@adamwojs adamwojs force-pushed the IBX-9415-add-support-contentaware-twig-functions branch from 43c90f4 to 1b53ca1 Compare February 12, 2025 06:41
@adamwojs adamwojs merged commit b435700 into 4.6 Feb 12, 2025
22 checks passed
@adamwojs adamwojs deleted the IBX-9415-add-support-contentaware-twig-functions branch February 12, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc needed The changes require some documentation Ready for QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants