IBX-88: Overridden debug:config command to use custom ContainerBuilder & restored ezplatform BC #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Nov 26, 2021
alongosz
force-pushed
the
ibx-88-symfony-debug-cmds-workaround
branch
from
ebe9a62 to
2f10239
Compare
ViniTou
approved these changes
Nov 26, 2021
Nattfarinn
approved these changes
Nov 26, 2021
alongosz
added a commit
that referenced
this pull request
Dec 1, 2021
9 tasks
alongosz
added a commit
that referenced
this pull request
Dec 3, 2021
For more details see https://issues.ibexa.co/browse/IBX-1589 * Overridden config:dump-reference to use custom ContainerBuilder (similar to #4) * Created extension name map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.0This PR replaces Symfony
debug:configcommand to be able to inject our own version of\Symfony\Bundle\FrameworkBundle\Command\BuildDebugContainerTraitwhich hardcodesContainerBuilderusage. To be able to properly debug all extensions which use legacy names (both 1st party and 3rd party), we need to inject there our custom Ibexa Container Builder introduced via #3.The only alternative way of overriding container builder there is via nasty Reflection usage: https://gist.github.com/alongosz/1a30cf7a2a8b30eb0f6806f68e972d2f. It produces less code, but is quite unclean.
Checklist:
Provided automated test coverage.// requires rather full stack coverage like Behat, so rather not worth it in the broader context$ composer fix-cs).