Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6502: Drafts under content #899

Merged
merged 4 commits into from
Sep 21, 2023
Merged

IBX-6502: Drafts under content #899

merged 4 commits into from
Sep 21, 2023

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Sep 7, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6502
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@tischsoic tischsoic added the Doc needed The changes require some documentation label Sep 7, 2023
@tischsoic tischsoic self-assigned this Sep 7, 2023
@tischsoic tischsoic marked this pull request as ready for review September 8, 2023 08:30
Steveb-p
Steveb-p approved these changes Sep 14, 2023
View reviewed changes
src/lib/Menu/MainMenuBuilder.php
@@ -27,6 +27,7 @@ class MainMenuBuilder extends AbstractBuilder implements TranslationContainerInt
{
/* Main Menu / Dashboard */
public const ITEM_DASHBOARD = 'main__dashboard';
public const ITEM_DRAFTS = 'main__drafts';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment missing. See other entries.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx merged commit 23204c0 into main Sep 21, 2023
@adamwojs adamwojs deleted the IBX-6502-draft-under-content branch September 26, 2023 08:10
@MagdalenaZuba MagdalenaZuba removed the Doc needed The changes require some documentation label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisztof kisztof kisztof approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@tischsoic tischsoic

@dew326 dew326

@ViniTou ViniTou

Labels
Feature New feature request Ready for QA Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.