Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5854: Added base backoffice path to adminUI config #860

Merged
merged 8 commits into from
Aug 30, 2023
Merged

IBX-5854: Added base backoffice path to adminUI config #860

merged 8 commits into from
Aug 30, 2023

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Aug 4, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5854
Bug fix? yes
New feature? yes
BC breaks? no
Tests pass? yes/no
Doc needed? no
License GPL-2.0

For @ibexa/javascript-dev,
we would also need to unify used cookies names, as atm we have:

second_menu_width
ibexa-tb-ibexa-category-filter-tree-%d-container-width
ibexa-tb-ibexa-taxonomy-tree-%d-+-container-width
ibexa-tb-ibexa-content-tree-%d-container-width
ibexa_adaptive_filters-is_expanded-ibexa_om_orders_list

Q&A:

This is just part of the solution for the issue. What needs to be checked here if backoffice path is always properly added to adminUI conig with different siteAccess configurations.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou requested review from a team August 4, 2023 14:18
dew326
dew326 reviewed Aug 22, 2023
View reviewed changes
src/bundle/Resources/config/ezplatform_default_settings.yaml Outdated
@@ -68,7 +68,7 @@ parameters:
ibexa.site_access.config.admin_group.user_edit.templates.create: '@@ibexadesign/user/create.html.twig'

# Content Tree Module
ibexa.site_access.config.admin_group.content_tree_module.load_more_limit: 30
ibexa.site_access.config.admin_group.content_tree_module.load_more_limit: 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure we want only 5 items?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad!!

@mikadamczyk mikadamczyk force-pushed the ibx-5854-exposed-backoffice-path branch from c49e195 to c1fcbed Compare August 28, 2023 08:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx merged commit c0fd4c8 into 4.5 Aug 30, 2023
@webhdx webhdx deleted the ibx-5854-exposed-backoffice-path branch August 30, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 left review comments

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.