Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5181 fix ui texts position #723

Merged
merged 9 commits into from
Jun 14, 2023
Merged

IBX-5181 fix ui texts position #723

merged 9 commits into from
Jun 14, 2023

Conversation

lionelakpagni
Copy link
Contributor

@lionelakpagni lionelakpagni commented Mar 2, 2023 •
edited by micszo
Loading

Question Answer
Tickets IBX-5181
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes/no
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lionelakpagni lionelakpagni requested review from dew326 and a team March 2, 2023 15:05
@dew326
Copy link
Contributor

dew326 commented Mar 3, 2023

Zrzut ekranu 2023-03-3 o 10 45 04
I'm not sure if this what we want to achieve.

@lionelakpagni
Copy link
Contributor Author

yes indeed, let me apply the css to the single filter bloc.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lionelakpagni
Copy link
Contributor Author

ping @dew326 PR updated

GrabowskiM
GrabowskiM approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@GrabowskiM GrabowskiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dew326
dew326 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With reported issues taken into account

@adamwojs
Copy link
Member

@lionelakpagni Could you please address @lucasOsti suggestions ?

@lionelakpagni
Copy link
Contributor Author

Hi @dew326 <can you please take a look at this ?
Thanks

@dew326 dew326 requested a review from lucasOsti June 7, 2023 08:28
@micszo micszo self-assigned this Jun 13, 2023
@micszo micszo mentioned this pull request Jun 13, 2023
Closed
=lionel Akpagni and others added 9 commits June 13, 2023 14:54
@dew326
IBX-5181 fix ui texts position
d29c4b4
@dew326
Revert "IBX-5181 fix ui texts position"
a724e28 
This reverts commit 0306a90.
@dew326
revert commit 0306a90 and fix text buttons
18edac4
@lionelakpagni @lucasOsti @dew326
Update src/bundle/Resources/public/scss/_filters.scss
9b2feab 
Co-authored-by: Łukasz Ostafin <ostafin.lucas@gmail.com>
@lionelakpagni @lucasOsti @dew326
Update src/bundle/Resources/public/scss/_search-form.scss
fa17797 
Co-authored-by: Łukasz Ostafin <ostafin.lucas@gmail.com>
@lionelakpagni @lucasOsti @dew326
Update src/bundle/Resources/public/scss/_filters.scss
46e3cbf 
Co-authored-by: Łukasz Ostafin <ostafin.lucas@gmail.com>
@lionelakpagni @lucasOsti @dew326
Update src/bundle/Resources/public/scss/_filters.scss
e51493d 
Co-authored-by: Łukasz Ostafin <ostafin.lucas@gmail.com>
@lionelakpagni @dew326
Update src/bundle/Resources/public/scss/_filters.scss
37e839b 
Co-authored-by: Dariusz Szut <dew326@gmail.com>
@dew326
prettier
5364674
@dew326 dew326 force-pushed the IBX-5181-fix-ui branch from 361d8c6 to 5364674 Compare June 13, 2023 12:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

micszo
micszo approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.4.4-dev with diff.

@dew326 dew326 merged commit efa6a9a into 4.4 Jun 14, 2023
@dew326 dew326 deleted the IBX-5181-fix-ui branch June 14, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@dew326 dew326

@micszo micszo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lionelakpagni @dew326 @adamwojs @GrabowskiM @micszo @lucasOsti @Gengar-i