-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: automated docker image build #44
Conversation
Signed-off-by: FaithKovi <faithkovivera@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, but this looks like it's going in the right direction!
pre-commit.ci run |
Signed-off-by: FaithKovi <faithkovivera@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ibLeDy I have made the requested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I've left a comment but this looks good!
Signed-off-by: FaithKovi <faithkovivera@gmail.com>
This looks good, I have #45 ready, so we can test it right away! Thanks for your contribution! |
Signed-off-by: FaithKovi faithkovivera@gmail.com
Closes #43