Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: automated docker image build #44

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Conversation

FaithKovi
Copy link
Contributor

@FaithKovi FaithKovi commented Oct 14, 2022

Signed-off-by: FaithKovi faithkovivera@gmail.com

Closes #43

Signed-off-by: FaithKovi <faithkovivera@gmail.com>
Copy link
Owner

@ibLeDy ibLeDy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, but this looks like it's going in the right direction!

.github/workflows/deployment.yml Outdated Show resolved Hide resolved
.github/workflows/deployment.yml Outdated Show resolved Hide resolved
.github/workflows/deployment.yml Outdated Show resolved Hide resolved
@ibLeDy
Copy link
Owner

ibLeDy commented Oct 17, 2022

pre-commit.ci run

Signed-off-by: FaithKovi <faithkovivera@gmail.com>
Copy link
Contributor Author

@FaithKovi FaithKovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibLeDy I have made the requested changes

.github/workflows/deployment.yml Outdated Show resolved Hide resolved
.github/workflows/deployment.yml Outdated Show resolved Hide resolved
.github/workflows/deployment.yml Outdated Show resolved Hide resolved
Copy link
Owner

@ibLeDy ibLeDy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've left a comment but this looks good!

.github/workflows/deployment.yml Outdated Show resolved Hide resolved
Signed-off-by: FaithKovi <faithkovivera@gmail.com>
@ibLeDy
Copy link
Owner

ibLeDy commented Nov 10, 2022

This looks good, I have #45 ready, so we can test it right away!

Thanks for your contribution!

@ibLeDy ibLeDy merged commit 8e2391f into ibLeDy:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated Docker image build and push to the deployment workflow
2 participants