Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: search for timezone #27

Merged
merged 2 commits into from
Oct 4, 2021
Merged

feat: search for timezone #27

merged 2 commits into from
Oct 4, 2021

Conversation

drzcola
Copy link
Contributor

@drzcola drzcola commented Oct 3, 2021

closes #25

ibLeDy
ibLeDy requested changes Oct 3, 2021
View reviewed changes
Copy link
Owner

@ibLeDy ibLeDy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, but this is really close!

timezone_converter/main.py Outdated Show resolved Hide resolved
timezone_converter/main.py Outdated Show resolved Hide resolved
timezone_converter/search_view.py Outdated Show resolved Hide resolved
timezone_converter/search_view.py Outdated Show resolved Hide resolved
@ibLeDy ibLeDy added enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest 2022 labels Oct 3, 2021
ibLeDy
ibLeDy approved these changes Oct 4, 2021
View reviewed changes
Copy link
Owner

@ibLeDy ibLeDy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibLeDy ibLeDy merged commit e17aaf7 into ibLeDy:main Oct 4, 2021
@ibLeDy
Copy link
Owner

ibLeDy commented Oct 4, 2021

Thanks for your contribution, I will create a new release ASAP!

@drzcola drzcola deleted the search branch October 23, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibLeDy ibLeDy ibLeDy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted PR accepted for Hacktoberfest 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a search option to the cli
2 participants
@drzcola @ibLeDy