Prevent immer from freeze operations. #4043
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Fixing a bug.
What's the new behavior?
After copy (editor.getFragment), the editor.operations is not frozen (then no crash due to any update). if in case you actually using immer 7+ though Slate using v5 but if the client code has other dependencies which using higher version of immer, finally the Slate could actually calling immer 7+.
How does this change work?
Like https://github.com/ianstormtaylor/slate/pull/3850/files#r480954559 suggested, but without upgrade the immer version in package.json
Have you checked that...?
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)Does this fix any issues or need any specific reviewers?
Fixes: #4034
Reviewers: @BrentFarese