Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problem with firefox returning Etc/ #12

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

ferrolive
Copy link
Contributor

ignore Etc timezones coming from the internationalization api

ignore Etc timezones coming from the internationalization api
@iansinnott
Copy link
Owner

Awesome, thanks @ferrolive. Can you provide a little more context on what was going on? What was the behavior before and what is it now?

@ferrolive
Copy link
Contributor Author

ferrolive commented Oct 28, 2017

Sure @iansinnott. Only Firefox the function was returning the Intl classEtc/GMT-X instead of Asia/XXXX IANA code . With the adjustment, it will return Asia/XXXX properly.

@iansinnott
Copy link
Owner

What is the ETC timezone?

I'd be happy to merge this in, I just don't want to break functionality for anyone else.

@ferrolive
Copy link
Contributor Author

ferrolive commented Oct 28, 2017

@iansinnott I think it's one of the IANA's time zone abbreviation format. Maybe you can have more details here ftp://ftp.iana.org/tz/data/etcetera. Normally, we expect jstz library to return always the "Continent/Zone" format (ex. America/New_York, Asia/Seoul). Somehow only Firefox does some crazy stuff with the Intl class that makes jstz return that format. It does not break the code for others.

@iansinnott iansinnott merged commit 73f4510 into iansinnott:master Oct 30, 2017
@iansinnott
Copy link
Owner

OK, merged and published as 2.0, just in case this change breaks anything for existing users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants