Major rewrite #51
Merged
Major rewrite #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue ianperrin#33 - rewrote setTimeout call
ran prettier
Signed-off-by: 73cirdan <73cirdan@gmail.com>
Signed-off-by: 73cirdan <73cirdan@gmail.com>
screenshot added
first take on rewriting the readme with new features
fix options table
Signed-off-by: 73cirdan <73cirdan@gmail.com>
refresh readme
Signed-off-by: 73cirdan <73cirdan@gmail.com>
Signed-off-by: 73cirdan <73cirdan@gmail.com>
Signed-off-by: 73cirdan <73cirdan@gmail.com>
elaborated on config
layout thanks, update intro
config option explained
typo
Signed-off-by: 73cirdan <73cirdan@gmail.com>
Get readme changes
…tructor and flags Signed-off-by: 73cirdan <73cirdan@gmail.com>
Signed-off-by: 73cirdan <73cirdan@gmail.com>
old bu file deleted
old screenshot
screenshot gallery
delete temp screenshots
added screenshot
typo
MagicMirror²
explanation
Signed-off-by: 73cirdan <73cirdan@gmail.com>
Signed-off-by: 73cirdan <73cirdan@gmail.com>
help needed
|
Yes - support setting the version to 2.0.0 and updating the readme so it references this ***@***.*** can you update the pull request?On 29 Mar 2024, at 20:18, cirdan ***@***.***> wrote:
@73cirdan commented on this pull request.
In package.json:
- "eslint-config-prettier": "^8.7.0",
- "eslint-plugin-jsdoc": "^40.0.3",
- "eslint-plugin-prettier": "^4.2.1",
- "mocha": "^10.2.0",
- "module-alias": "^2.2.2",
- "prettier": "^2.8.4",
- "stylelint": "^15.3.0",
- "stylelint-config-standard": "^31.0.0",
- "stylelint-prettier": "^3.0.0"
- },
- "dependencies": {
- "f1-api": "^1.2.0",
- "ical-generator": "^3.6.1"
- }
+ "name": "mmm-formula1",
+ "version": "0.8.0",
not sure how that happened. We discussed about setting it to 2.0.0 in the release to come
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
url's back to ianperrin version to 2.0.0
rewrote intro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the module a written in the readme
redid the lint part (prettier, eslint,stylelint), added html prettier plugin
the workflow part is not in my code, leave it untouched at your side?
the unittest part did not work on my side, was it working for you ?