Skip to content

Commit

Permalink
Testsfix (#425)
Browse files Browse the repository at this point in the history
* test against python 3.12

* update cassettes

Response formats aren't the same as what new requests is expecting, or something like that

* Update tests

After re-running the cassettes had to update some expectations to match the newly pulled data

* expand testing to 3.12

Might as well add it in while I'm fixing these things

* Drop 3.12

Tables doesn't seem to support it.
Getting near the point where I have to rebuild this library without the stupid HDFS dependency

* bump poetry and nox versions

Match what I'm running locally

* version updates

* Drop support for 3.9 and 3.8

pyvcr requires 3.10 now and I don't feel like figuring out how to support older versions

* explicitly import scwds

Shuts ruff up

* remove static methods check

This is just testing that a function wrapped in the class does the same thing as the unwrapped
a) that's silly
b) I'm testing way too much stuff for one test and I don't feel like refactoring it since the premise is dumb
c) When it fails it creates side effects that fail other tests
  • Loading branch information
ianepreston authored Mar 4, 2024
1 parent 4b67323 commit 54e93ab
Show file tree
Hide file tree
Showing 36 changed files with 291,735 additions and 564,739 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: '3.10'
python-version: '3.11'
architecture: x64
- run: pip install nox==2022.11.21
- run: pip install nox-poetry==1.0.2
- run: pip install poetry==1.3.1
- run: nox --sessions tests-3.10 coverage
- run: pip install nox==2023.04.22
- run: pip install nox-poetry==1.0.3
- run: pip install poetry==1.8.2
- run: nox --sessions tests-3.11 coverage
env:
CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}}
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.11', '3.10', '3.9', '3.8']
python-version: ['3.11', '3.10']
name: Python ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
architecture: x64
- run: pip install nox==2022.11.21
- run: pip install nox-poetry==1.0.2
- run: pip install poetry==1.3.1
- run: pip install nox==2023.4.22
- run: pip install nox-poetry==1.0.3
- run: pip install poetry==1.7.1
- run: nox --python ${{ matrix.python-version }}
env:
CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}}
2 changes: 0 additions & 2 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
python_versions = [
"3.11",
"3.10",
"3.9",
"3.8",
]
python_version = python_versions[0]

Expand Down
235 changes: 117 additions & 118 deletions poetry.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ documentation = "https://stats-can.readthedocs.io"
keywords = ["statistics", "Canada", "data", "API"]

[tool.poetry.dependencies]
python = ">=3.8,<4.0"
python = ">=3.10,<4.0"
requests = ">=2.20"
h5py = ">=2.10"
tables = ">=3.6"
Expand Down
1 change: 1 addition & 0 deletions src/stats_can/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from stats_can.sc import update_tables
from stats_can.sc import vectors_to_df
from stats_can.sc import vectors_to_df_local
from stats_can import scwds
from stats_can.scwds import get_changed_cube_list
from stats_can.scwds import get_changed_series_list
from stats_can.scwds import get_cube_metadata
Expand Down
Loading

0 comments on commit 54e93ab

Please sign in to comment.