Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional callback for activity changes #11

Merged
merged 3 commits into from
Nov 5, 2017
Merged

Add optional callback for activity changes #11

merged 3 commits into from
Nov 5, 2017

Conversation

amelchio
Copy link

This allows the client to know about external activity changes as soon as they are reported by the Harmony Hub.

This lets the client know about external activity changes as soon as they
are reported by the Harmony Hub.

The hub will apparently close the connection after 66 seconds, so a lower
keepalive interval is needed for a reliable connection.
@amelchio
Copy link
Author

amelchio commented Nov 5, 2017

Hi @iandday!

Can you please let us know whether this repo is still maintained?

I would prefer not to create another fork so please take a little time within the next week to let us know the status of your project .

Thanks!

@iandday
Copy link
Owner

iandday commented Nov 5, 2017

Hi amelchio,
I was traveling for work this week and didnt have any time to look through these, I just browsed through the code changes and they look great! I'm going to take a closer look tomorrow and try them out on my hubs. If all goes well i'll push the new version, it'll be great to see the new functions in hass

@amelchio
Copy link
Author

amelchio commented Nov 5, 2017

That's great to hear! There is no rush, just didn't want to wait indefinitely :)

@iandday iandday merged commit 795871e into iandday:master Nov 5, 2017
@iandday
Copy link
Owner

iandday commented Nov 5, 2017

these changes look great, thank you.

I removed the token functionality completely from all ha_* functions. I'm going to publish this as 1.0.17, there doesnt look to be to many changes to be made on the HASS module to remove all references to auth tokens.

@amelchio
Copy link
Author

amelchio commented Nov 5, 2017

Thank you, that's very nice. I will get my Home Assistant PR updated so we can soon enjoy these improvements :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants