Option to assign response logs
#2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamolegga
approved these changes
Dec 23, 2024
|
@flovouin thank you for fantastic work. Could you squash commits in one? And I'll do the rest |
flovouin
force-pushed
the
assign-response
branch
from
21c1673 to
79e4ea7
Compare
|
Thanks for the quick response @iamolegga! I've merged the two commits into one. |
|
released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a few issues around not being able to assign response logs, mainly this one. The follow up has been to document this feature as not supported.
However I've found a way to assign response logs as well, rather painlessly. This is a proposal to add an option to support that. I've implemented this as an option such that the default behaviour wouldn't change. Also, because this uses
setBinding, this effectively changes the existing response logger rather than create a child logger (which wouldn't work).I couldn't find a reason why this solution hadn't been considered, but maybe there are downsides I haven't though of. Feel free to comment on that.
Cheers,