Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Array-type default export mock (#265) #266

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

iambumblehead
Copy link
Owner

@iambumblehead iambumblehead commented Nov 4, 2023

closes #265

thanks @altearius for the unit-test. It feels like you've finished this for me and adding three lines or so was effortless because of the test

@iambumblehead
Copy link
Owner Author

The main person who would normally review, @koshic, is usually not active during this time window, but it is probably safe to merge and publish nowish because the change is small and specific and probably safe

@iambumblehead iambumblehead merged commit 722e5a8 into main Nov 4, 2023
10 checks passed
@iambumblehead iambumblehead deleted the enable-mocking-array branch November 4, 2023 02:10
@koshic
Copy link
Collaborator

koshic commented Nov 5, 2023

@iambumblehead thx for PR, looks safe )

@iambumblehead
Copy link
Owner Author

I learned these two things recently,

  1. callbacks perform better than async-await
  2. regexp is slow; startsWith and endsWith are much faster, followed by equality operators ===

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when mocking a file that exports an array.
3 participants