Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memory warning in iOS App. #156

Merged
merged 1 commit into from
Jul 22, 2016
Merged

Conversation

h4v1nfun
Copy link
Contributor

Refactor iOS App code.
Remove memory warning in iOS App.

Refactor iOS App code.
Remove memory warning in iOS App.
@volksport
Copy link

If this actually does the trick this is worth a release asap!

@iam4x
Copy link
Owner

iam4x commented Jul 22, 2016

@AbelIngrand Can you review this please? Since it's modifying your code.

@Abeldvlpr
Copy link
Contributor

Seems good to me for the refactoring part but I don't see how it fixes the memory warning.

@Abeldvlpr
Copy link
Contributor

Tested it and confirmed by @nikhdpro in #121

@Abeldvlpr Abeldvlpr merged commit 14afe01 into iam4x:master Jul 22, 2016
@iam4x iam4x added this to the 1.1.2 milestone Jul 22, 2016
@iam4x
Copy link
Owner

iam4x commented Jul 22, 2016

🚢

@volksport
Copy link

When you get a chance can you cut a release with these changes? Appreciated!

@danielsantiago
Copy link

danielsantiago commented Jul 22, 2016

I implement the code from 14afe01 and still get the memory error but this time around one hour instead of 15 minutes (without the patch). Also because of this I got banned :-/

2016-07-22 17:01:17.900 Pokemon WebSpoof[31187:7596456] Received memory warning.
2016-07-22 17:09:05.960 Pokemon WebSpoof[31187:7596456] Received memory warning.
2016-07-22 17:28:00.188 Pokemon WebSpoof[31187:7596456] Received memory warning.
2016-07-22 17:59:01.137 Pokemon WebSpoof[31187:7596456] Received memory warning.
2016-07-22 18:06:44.238 Pokemon WebSpoof[31187:7596456] Received memory warning.
Message from debugger: Terminated due to memory issue

@h4v1nfun
Copy link
Contributor Author

@danielsantiago i'm afraid there's nothing we can do about that. Pokemon Go simply eats too much memory! in my testing i've managed to get about 3h of app open, after a reboot (iPhone 6), then i've got that terminated due to memory issue, but has you can see in xCode app memory stays in the 4.2 ~ 4.7 MB constantly. With a more powerful phone like the 6(+)s or the SE witch both have 2 GB of RAM i don't think this is gonna be a issue.

@iam4x iam4x added this to the 1.2.0 milestone Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants