-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove memory warning in iOS App. #156
Conversation
Refactor iOS App code. Remove memory warning in iOS App.
If this actually does the trick this is worth a release asap! |
@AbelIngrand Can you review this please? Since it's modifying your code. |
Seems good to me for the refactoring part but I don't see how it fixes the memory warning. |
🚢 |
When you get a chance can you cut a release with these changes? Appreciated! |
I implement the code from 14afe01 and still get the memory error but this time around one hour instead of 15 minutes (without the patch). Also because of this I got banned :-/ 2016-07-22 17:01:17.900 Pokemon WebSpoof[31187:7596456] Received memory warning. |
@danielsantiago i'm afraid there's nothing we can do about that. Pokemon Go simply eats too much memory! in my testing i've managed to get about 3h of app open, after a reboot (iPhone 6), then i've got that terminated due to memory issue, but has you can see in xCode app memory stays in the 4.2 ~ 4.7 MB constantly. With a more powerful phone like the 6(+)s or the SE witch both have 2 GB of RAM i don't think this is gonna be a issue. |
Refactor iOS App code.
Remove memory warning in iOS App.