Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch mode support? #9

Closed
mikecann opened this issue Mar 30, 2021 · 3 comments · Fixed by #10
Closed

Watch mode support? #9

mikecann opened this issue Mar 30, 2021 · 3 comments · Fixed by #10
Assignees
@iam-medvedev
Labels
bug Something isn't working released

Comments

@mikecann
Copy link

mikecann commented Mar 30, 2021 •
edited
Loading

Perhaps im doing something wrong but it seems like when you put esbuild into watch mode then make a change to a less file esbuild doesnt reload. Is this the responsability of this plugin esbuild?

Perhaps watchFiles or watchDirs needs to be used? https://esbuild.github.io/plugins/#load-results
@iam-medvedev iam-medvedev self-assigned this Mar 31, 2021
@iam-medvedev iam-medvedev added the bug Something isn't working label Mar 31, 2021
iam-medvedev added a commit that referenced this issue Apr 1, 2021
@iam-medvedev
fix: 🐛 watch mode
ad1dce3 
✅ Closes: #9
@iam-medvedev iam-medvedev mentioned this issue Apr 1, 2021
Merged
iam-medvedev added a commit that referenced this issue Apr 1, 2021
@iam-medvedev
fix: 🐛 watch mode (#10)
3480415 
✅ Closes: #9
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

🎉 This issue has been resolved in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iam-medvedev
Copy link
Owner

@mikecann can you check the latest version of package?

@mikecann
Copy link
Author

mikecann commented Apr 1, 2021

@iam-medvedev just did and it works! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iam-medvedev iam-medvedev

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 watch mode iam-medvedev/esbuild-plugin-less
2 participants
@mikecann @iam-medvedev