Fix StationPropertyRenderer import #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasDov
approved these changes
Dec 17, 2024
aruniverse
reviewed
Dec 17, 2024
| @@ -57,7 +57,7 @@ const AuthorizationProvider = clientId | |||
| redirect_uri: "/auth/callback", | |||
| silent_redirect_uri: "/auth/silent", | |||
| post_logout_redirect_uri: "/", | |||
| scope: "itwinjs imodelaccess:read imodels:read itwins:read openid profile", | |||
| scope: "itwin-platform itwinjs openid profile", | |||
There was a problem hiding this comment.
the only scope we need should be itwin-platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like top-level await import does not work in vite production builds due to problem in how rollup chunking works: rollup/rollup#4708
We end up in a situation were
ITwinJsAppchunk is awaiting forStationPropertyValueRendererchunk to load whileStationPropertyValueRendererimports stuff fromITwinJsApp. Replacedawait importthat was needed due toStationPropertyValueRenderermodule having side effects withregisterStationPropertyFeature.Additionally:
jsonlanguage worker for monaco editor as it is the only language rules editor uses.