Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to iTwin.js 3.0 part 1 #11

Merged
merged 50 commits into from
Dec 6, 2021
Merged

Upgrade to iTwin.js 3.0 part 1 #11

merged 50 commits into from
Dec 6, 2021

Conversation

ziyzhu
Copy link
Contributor

@ziyzhu ziyzhu commented Oct 28, 2021 •
edited
Loading

PCF has been using iTwin.js 2.16.10. This PR upgrades PCF to use the dev build 3.0.0-dev.127.

With a few minor API changes:

  1. subjectKey => subjectNodeKey, loaderKey => loaderNodeKey
  2. await DMO.modifyProps and DMO.doSyncInstance
  3. pass in PConnector (as shared memory) to DMO.modifyProps
  4. BaseApp.run() => BaseApp.runConnectorJob()
  5. Add BaseApp.nonInteractiveSignin() with service app client setup

@ziyzhu ziyzhu changed the title Adopt iTwin.js 3.0 Upgrade to iTwin.js 3.0 part 1 Dec 6, 2021
@ziyzhu ziyzhu marked this pull request as ready for review December 6, 2021 15:34
@ziyzhu ziyzhu merged commit 6788bfe into main Dec 6, 2021
@ziyzhu ziyzhu deleted the use-3.0 branch December 6, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ziyzhu