UI: Make tree node modicifation detection more robust #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saskliutas
approved these changes
Mar 24, 2021
DanEastBentley
approved these changes
Mar 24, 2021
Merged
|
@Mergifyio backport 2.14.x |
|
Command
|
|
@Mergifyio backport release/2.14.x |
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2021
(cherry picked from commit ebbfb43)
|
Command
|
roluk
added a commit
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
immerv8.0.2+ exposed a flaw in the way node additions/removals/modifications were detected via patches. The old implementation used to duplicate same node ids across multiple returned arrays, resulting in unnecessary React state updates.The new approach aims to be more robust but is by no means perfect. The amount of code required to make it fully reliable would be unjustifiable as I wasn't able to come up with a test case that would break this new implementation.
Added some more tests to help catch future problems with
immer.