Fix duplicate Bing map attributions. (#7408)

(cherry picked from commit dbbdc0a)
iTwin · Nov 20, 2024 · 4bc475c · 4bc475c
1 parent 82b3697
commit 4bc475c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/common/changes/@itwin/core-frontend/master_2024-11-20-15-45.json b/common/changes/@itwin/core-frontend/master_2024-11-20-15-45.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-frontend",
+      "comment": "Fix duplicate Bing map attributions.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-frontend"
+}
diff --git a/core/frontend/src/tile/map/ImageryProviders/BingImageryProvider.ts b/core/frontend/src/tile/map/ImageryProviders/BingImageryProvider.ts
@@ -136,9 +136,12 @@ export class BingMapsImageryLayerProvider extends MapLayerImageryProvider {
     for (const tile of tiles) {
       if (tile instanceof MapTile) {
         // compare to the set of Bing attributions that we have not yet matched.
-        for (const attribution of unmatchedSet) {
-          if (attribution && attribution.matchesTile(tile, this._mapTilingScheme)) {
+        for (let iAttr = 0; iAttr < unmatchedSet.length; iAttr++) {
+          const attribution = unmatchedSet[iAttr];
+          if (attribution.matchesTile(tile, this._mapTilingScheme)) {
             matchingAttributions.push(attribution);
+            unmatchedSet.splice(iAttr, 1);
+            break;
           }
         }
       }