Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate having more structured testing with a case matrix #155

Open
nick4598 opened this issue Feb 26, 2024 · 0 comments
Open

Investigate having more structured testing with a case matrix #155

nick4598 opened this issue Feb 26, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nick4598
Copy link
Collaborator

nick4598 commented Feb 26, 2024

BranchProvenanceInitializer.test.ts already does this to an extent with sourceTargetFedGuidToAspectCountMap and the way the test cases are generated.

A lot of test cases in IModelTransformerHub.test.ts and IModelTransformer.test.ts and may have some overlap in terms of what scenarios they test, and its hard to currently tell what all is being tested with the way they are currently setup.

A good starting point may be to take a look at the following 3 test cases:
it("should be able to handle relationship delete using new relationship provenance method with no fedguids"
it("should be able to handle relationship delete using old relationship provenance method with no fedguids"
it("should be able to handle relationship delete using fedguids"

and generate them programmatically. This may need to be more complex than how it is done in BranchProvenanceInitializer.test.ts, perhaps we need to create a new class 'Case' which captures certain options that need to be set for the transformer in certain test cases. An example of this is we need to toggle 'forceOldRelationshipProvenanceMethod' for the above 3 test cases, but we probably don't need to toggle this for any of the other 90+ test cases which currently run.

@nick4598 nick4598 added the enhancement New feature or request label Feb 26, 2024
@nick4598 nick4598 self-assigned this Feb 26, 2024
nick4598 added a commit that referenced this issue Feb 28, 2024
I removed the fixme about structured testing and added it to work item:
#155.

Removed transformerresumption API and fixmes associated with it.
nick4598 added a commit that referenced this issue Nov 20, 2024
I removed the fixme about structured testing and added it to work item:
#155.

Removed transformerresumption API and fixmes associated with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant