-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added common reliable check to detect jest,vitest and mocha testing framework. #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Is there any other better approach to do this? |
mayank99
reviewed
Jan 30, 2024
r100-stack
reviewed
Jan 30, 2024
packages/itwinui-react/src/core/ThemeProvider/ThemeProvider.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Rohan Kadkol <45748283+rohan-kadkol@users.noreply.github.com>
mayank99
reviewed
Jan 30, 2024
mayank99
reviewed
Jan 30, 2024
mayank99
reviewed
Jan 30, 2024
mayank99
reviewed
Jan 30, 2024
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
r100-stack
reviewed
Jan 30, 2024
mayank99
approved these changes
Jan 30, 2024
…/iTwin/iTwinUI into siddhant/detect_test_environment
r100-stack
approved these changes
Jan 30, 2024
mayank99
reviewed
Jan 30, 2024
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1784, fixes isJest/IsDev issues.
Changes
Added new checks to detect test frameworks other than
jest
:vitest
(from console-fail-test, see thread)mocha
(from console-fail-test, see thread)Testing
Dev errors not showing. (vitest)
mocha check tested in isolation (see thread)
Docs
N/A