[electron] require reauth after scopes change #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-polinsky
requested review from
aruniverse,
anmolshres98 and
MichaelSwigerAtBentley
as code owners
ben-polinsky
commented
Dec 11, 2024
ben-polinsky
commented
Dec 13, 2024
Closed
|
@GytisCepk, @MichaelSwigerAtBentley, @anmolshres98 We are finally good here if you could review :) Apologies again for the bloat, but we're in a better place with integration tests. |
anmolshres98
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user altered the scopes in an application config authentication would fail until the user manually signed out and signed back in.
With this change, we store scopes from configuration alongside the token. If the scopes don't match, we delete the token and require re-authentication.
#270
starts moving away from parcel #277