Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
export
and subpaths, to fully support CJS and ESM, we need each subpath to containimport
andrequire
.Previously,
./Renderer
didn't support CJS, because it didn't have arequire
field. This would cause problems in packages, likeitwinjs/core
core-full-stack-tests
, that consumes both Main and Renderer, but outputs CJS files. At build time, this wouldn't be caught, but during runtime, it would throw aPACKAGE_PATH_NOT_SUPPORTED
, because when it tried to use the Renderer subpath, it couldn't find a valid CJS path.Vice versa, with
./Main
in ESM outputted files.This issue is fixed by adding both
import
andrequire
and their valid values to each subpath.