Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'networkidle' from Tests #269

Closed
MichaelSwigerAtBentley opened this issue Nov 1, 2024 · 0 comments · Fixed by #279
Closed

Remove 'networkidle' from Tests #269

MichaelSwigerAtBentley opened this issue Nov 1, 2024 · 0 comments · Fixed by #279
Assignees
@ben-polinsky
Labels
good first issue Good for newcomers

Comments

@MichaelSwigerAtBentley
Copy link
Contributor

There are also several waitForLoadState('networkidle') calls in the electron package's integration tests.

Playwright's waitForLoadState('networkidle') is discouraged

The Integration Tests should be refactored to not rely on these calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-polinsky ben-polinsky

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[browser] Integration test app - replace parcel with vite iTwin/auth-clients
2 participants
@ben-polinsky @MichaelSwigerAtBentley