Adding rush change -v to ci.yml
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently this is not that simple, I'll have to get back to this later. |
kckst8
approved these changes
Sep 6, 2023
|
ended being due to the shallow fetch GH actions do by default. It wasn't getting enough of the history on the main branch in order to do the comparison for a rush change. Specifying Added Node 14 while I was at it. I saw @ben-polinsky's other PR to swap out node-sass so we can move up to Node 18+ so didn't bother trying. |
calebmshafer
approved these changes
Nov 10, 2023
raplemie
commented
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we are requesting rush changes to be filed.
Resolves #94