Fix iTwin favorites and add favorites to iTwinGrid table view #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruniverse
reviewed
Nov 22, 2024
packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinFavorites.ts
Show resolved
Hide resolved
aruniverse
reviewed
Nov 22, 2024
packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinFavorites.ts
Show resolved
Hide resolved
auto-merge was automatically disabled
November 22, 2024 20:22
Pull request was converted to draft
arome
changed the title
…ching from favorites tab to other tab, then back to favorites tab quickly.
aruniverse
reviewed
Nov 25, 2024
packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinFavorites.ts
Outdated
Show resolved
Hide resolved
aruniverse
reviewed
Nov 25, 2024
packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinData.ts
Outdated
Show resolved
Hide resolved
aruniverse
reviewed
Dec 2, 2024
packages/modules/imodel-browser/src/containers/ITwinGrid/ITwinTile.tsx
Outdated
Show resolved
Hide resolved
packages/modules/imodel-browser/src/containers/ITwinGrid/useITwinFavorites.ts
Outdated
Show resolved
Hide resolved
aruniverse
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to recent PR. Avoid throwing error when status is 204.
Also included the option to favorite/unfavorite in the table view mode