Revert iTwinUI v3

[veekeys]

Changed version of iTwinUI to v2. Some major changes reverted, some kept.
Checked storybook, looked OK.
For manage-versions package made changes as none, thought #112 would be the one getting the patch.. But probably should make 2 separate releases anyway ?

[raplemie]

@Pooja17-bentley, @anirban-chakraborty-bentley, @SorexBentley, @DanishMehmood-bit, @aruniverse, @manwadkaraksh, @kckst8

With this PR we are looking at reverting the changes we introduced last week with iTwinUI V3, the main reason being the theme not being synched between V2 and V3, an upcoming minor to iTwinUI V3 should fix this, but we have pending PRs and upcoming requests that will make this a bit difficult for the time being to stay on V3, on top of the missed Breaking change I tries to address in #113.

The plan short term is to release this as a patch, if you already added the styles to your application, it will not be a problem because it will not impact these packages, and you will be ready for the next version, which will be a Major, when the few issues are adressed by iTwinUI V3.

I cant reach out to everyone, but you are the latest ones that contributed or reached out directly to me with these changes.

[aruniverse]

an upcoming minor to iTwinUI V3 should fix this

do we have an eta for this?

[raplemie]

an upcoming minor to iTwinUI V3 should fix this

do we have an eta for this?

The PR is already merged, I don't know what is iTwinUI release schedule.
iTwin/iTwinUI#1735
@mayank99 is the release date for 3.1 known ?

[mayank99]

The PR is already merged, I don't know what is iTwinUI release schedule. iTwin/iTwinUI#1735 @mayank99 is the release date for 3.1 known ?

3.1.0 was released just now! Try it out and let us know if the theme inheritance works like you'd expect.

---

Do you still want to revert to v2 or is this PR no longer necessary? Could just merge #112 and #113 instead and make a patch release.

[aruniverse]

3.1.0 was released just now! Try it out and let us know if the theme inheritance works like you'd expect.

worked for me in my test app

[raplemie]

@aruniverse Can you confirm that you dont see that weird light theme flicker that I get in Storybook ?

chrome_l3ScrXVW33.mp4

[aruniverse]

Confirm,

Screen.Recording.2023-12-13.at.3.15.05.PM.mov

[aruniverse]

3.1.0 was released just now! Try it out and let us know if the theme inheritance works like you'd expect.

worked for me in my test app

you can play with it here, https://viewer.itwin.dev/, see 3.0.x deployed here

[anirban-chakraborty-bentley]

@raplemie Now that we have 3.1.0 are we still planning to proceed with this PR?

[veekeys]

But if I understand correctly, we are not running away from the need of importing styles.css in consuming app and we need to document that throughout these packages...?
There are some visual impact @Pooja17-bentley pointed out, so I would still rather go with this one, let the changes be merged from #112 and calmly then update again to v3 and verify the scope of impact.

[Pooja17-bentley]

But if I understand correctly, we are not running away from the need of importing styles.css in consuming app and we need to document that throughout these packages...? There are some visual impact @Pooja17-bentley pointed out, so I would still rather go with this one, let the changes be merged from #112 and calmly then update again to v3 and verify the scope of impact.

I have tried with new itwinui-react v3.1.0 and importing styles in application using alias to v3 version but still getting below issues for manage-version package:

1. Not getting scroll when we have numerous changesets/nv in tables.
2. For create/update modal-
   
3. Changes tab content loading issue on its first render
   
   Note: - the above loading issue occurs on using composition API for tab, with legacy API we don't get this issue.

[raplemie]

Given the visual changes, we'll move on with this and then release a proper Major update, with 3.1.0 already fixing the theming, it is just a question of reacting to different changes, but there is still the styles.css import which is a breaking change and shouldnt have made it in a minor, I also noticed that we were using deprecated stuff in the UploadImage component, so we'll take some time to fix those correctly and release the Major then.

Some of the people that already updated noticed it, but we still have a lot of usage using the previous minor so not everyone have hit this issue yet, for those, we should make it clear and not continue on our mistake.

[raplemie]

Let's go with this, we will move back to iTwinUI V3 soon to help adoption with a clear Major and documentation.