fix issue for optional string overrides

iTwin · Nov 10, 2023 · 97c6713 · 97c6713
1 parent 65b7a2d
commit 97c6713
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 13 deletions.
diff --git a/...ages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.test.tsx b/...ages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.test.tsx
@@ -54,9 +54,7 @@ describe("ChangesTab", () => {
       within(cells[5] as HTMLElement).getByTitle(
         defaultStrings.createNamedVersion
       );
-      within(cells[5] as HTMLElement).getByTitle(
-        defaultStrings.informationPanel
-      );
+      within(cells[5] as HTMLElement).getByTitle("Information Panel");
     });
   });
 
@@ -103,9 +101,7 @@ describe("ChangesTab", () => {
       changesets: MockedChangesetList(),
     });
     const rowgroup = screen.getAllByRole("rowgroup")[0];
-    const infoIcons = within(rowgroup).queryAllByTitle(
-      defaultStrings.informationPanel
-    );
+    const infoIcons = within(rowgroup).queryAllByTitle("Information Panel");
     const rows = within(rowgroup).queryAllByRole("row");
 
     expect(infoIcons.length).toBe(rows.length);

diff --git a/packages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.tsx b/packages/modules/manage-versions/src/components/ManageVersions/ChangesTab/ChangesTab.tsx
@@ -73,7 +73,7 @@ const ChangesTab = (props: ChangesTabProps) => {
           },
           {
             id: "CREATOR",
-            Header: stringsOverrides.user,
+            Header: stringsOverrides.user ?? "User",
             accessor: "createdBy",
             maxWidth: 220,
             Cell: (props: CellProps<Changeset>) => {
@@ -130,7 +130,9 @@ const ChangesTab = (props: ChangesTabProps) => {
                     <SvgNamedVersionAdd />
                   </IconButton>
                   <IconButton
-                    title={stringsOverrides.informationPanel}
+                    title={
+                      stringsOverrides.informationPanel ?? "Information Panel"
+                    }
                     styleType="borderless"
                     onClick={() => handleInfoPanelOpen(changeset)}
                     size="small"

diff --git a/packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.test.tsx b/packages/modules/manage-versions/src/components/ManageVersions/ManageVersions.test.tsx
@@ -119,9 +119,7 @@ describe("ManageVersions", () => {
       within(cells[5] as HTMLElement).getByTitle(
         defaultStrings.createNamedVersion
       );
-      within(cells[5] as HTMLElement).getByTitle(
-        defaultStrings.informationPanel
-      );
+      within(cells[5] as HTMLElement).getByTitle("Information Panel");
     });
     expect(mockGetChangesets).toHaveBeenCalledWith(MOCKED_IMODEL_ID, {
       top: 100,
@@ -317,7 +315,7 @@ it("should render with changesets tab opened", async () => {
     within(cells[5] as HTMLElement).getByTitle(
       defaultStrings.createNamedVersion
     );
-    within(cells[5] as HTMLElement).getByTitle(defaultStrings.informationPanel);
+    within(cells[5] as HTMLElement).getByTitle("Information Panel");
   });
 });
 

diff --git a/packages/modules/manage-versions/src/components/ManageVersions/VersionsTab/VersionsTab.tsx b/packages/modules/manage-versions/src/components/ManageVersions/VersionsTab/VersionsTab.tsx
@@ -50,7 +50,7 @@ const VersionsTab = (props: VersionsTabProps) => {
           },
           {
             id: "CREATOR",
-            Header: stringsOverrides.user,
+            Header: stringsOverrides.user ?? "User",
             accessor: "createdBy",
             maxWidth: 220,
             Cell: (props: CellProps<NamedVersion>) => {