Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dev packages #1089

Merged
merged 2 commits into from
Apr 2, 2019
Merged

chore: update dev packages #1089

merged 2 commits into from
Apr 2, 2019

Conversation

gchoqueux
Copy link
Contributor

Description

update all dev packages

@gchoqueux gchoqueux added this to the 2.10.0 milestone Apr 1, 2019
@gchoqueux
fix(test): inverse range with wheel mouse event.
bbfddcd 
On the travis server, the range is negative.
zarov
zarov approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@zarov zarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the fix to the "moderate severity vulnerability" (if you are also getting it ?) before merging ? (npm audit fix)

@gchoqueux
Copy link
Contributor Author

npm audit fix

it returns vulnerability required manual review and could not be updated for mocha.
Mocha vulnerability will fixed in 6.1.0 mochajs/mocha#3842

@gchoqueux gchoqueux merged commit 42bd1c4 into iTowns:master Apr 2, 2019
@gchoqueux gchoqueux deleted the update_packages branch April 2, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarov zarov zarov approved these changes

Assignees
No one assigned
Labels
chore 🚚
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gchoqueux @zarov