Add feature: Local map overlays for mission planner #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed issue where panning would not work when mouse-down was over a feature imported by the user in mission planner
…at werent custom user features
Not working, but I want to keep working on a different machine
Not working, but I want to keep working on a different machine
paulwrath1223
commented
Aug 8, 2024
| @@ -9649,4 +9649,4 @@ | |||
| } | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
I accidentally pushed some changes my IDE made to this file, and then undid them manually, but for some reason this is still in the diff. Feel free to not merge this file
There was a problem hiding this comment.
no big deal. probably extra empty line at the end of file
|
@Scavanger maybe worth to keep in mind when porting GF to 8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for the user to drag and drop a GEO file containing property lines, trails, waypoints, flight restricted areas, or anything else on to the map. The change does not affect anything about the actual mission and is purely for visual reference.
While the feature is similar to GEO-fencing, an upcoming rumored addition to iNav, this allows the user to easily import existing data in almost any applicable format (GEOJSON, KML, GPX, TOPOJSON, and IGC) to be able to more easily identify or plan around various landmarks in mission planner.
To put it bluntly, I am not a JS dev, and some conventions may be missing. Especially those specific to this project. But I did my best to emulate the style in the rest of the project, if not with more comments. If there are any issues I am in the iNav discord under the name BeanTime, and I'm always open to suggestions or changes that need to be made.