Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite desk_height_sensor.h as external component #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phntxx
Copy link

@phntxx phntxx commented Oct 6, 2024

Hi 👋🏻

Given that custom components for esphome are deprecated, I decided to rewrite desk_height_sensor.h as an external component instead.

This works by essentially adding some boilerplate code around the preexisting codebase of desk_height_sensor.h and has the exact same functionality as if one were to include desk_height_sensor.h within their esphome yaml file.

@iMicknl
Copy link
Owner

iMicknl commented Oct 13, 2024

@phntxx thanks, I will have a look! Just be aware there is a v2 branch (which we should merge soon), where we have already additional improvements. #67 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants