Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add ButtonGroup component #33

Merged
merged 11 commits into from
Mar 8, 2018
Merged

Add ButtonGroup component #33

merged 11 commits into from
Mar 8, 2018

Commits on Mar 1, 2018

  1. Add ButtonGroup component

    This adds a component for grouping Buttons together. It simply adds the
    correct borderRadius to any of it's children that are buttons and passes
    through the rest of the props. Along with this, the group can be
    disabled rather than having to disable all buttons individually.
    Andrew Pirondini committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    87fc098 View commit details
    Browse the repository at this point in the history
  2. Add children PropType validation and export ButtonGroup

    Andrew Pirondini committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    a3f7079 View commit details
    Browse the repository at this point in the history
  3. Make GroupedButton component fit on one line

    Andrew Pirondini committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    c81f839 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'master' into add-buttongroup-component

    Andrew Pirondini committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    0c2b0e6 View commit details
    Browse the repository at this point in the history
  5. style: Make GroupedButton on one line

    There are still CI failures. Hopefully this actually fixes them.
    Andrew Pirondini committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    323d8f5 View commit details
    Browse the repository at this point in the history
  6. test: Add missing ButtonGroup test

    This adds new tests for the ButtonGroup with snapshots. It also pushes
    the latest version of the toolbox distribution since that got borked
    during merging.
    Andrew Pirondini committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    a9a8478 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. fix(buttongroup): Fix disabled prop being overridden

    The issue was that the disabled prop was being overridden by the more
    generic {...child.props}. To fix this I just had to reorder the props.
    
    Along with this I made several style changes suggested in CR.
    Andrew Pirondini committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    a85c38b View commit details
    Browse the repository at this point in the history
  2. fix(buttongroup): Remove borderRight from middle elements

    This fixes the issue of having both the borderLeft of one button and the
    borderRight of the other button creating a border with twice the normal
    width. Instead, we remove the borderRight for all but the last button
    and use only the borderLefts to separate buttons.
    Andrew Pirondini committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    c707efd View commit details
    Browse the repository at this point in the history
  3. test(buttongroup): Add test case for non-button children

    This adds the test case for when a ButtonGroup has other children
    besides Button components. It should, in this case, not alter the other
    children as the updated shapshots show.
    Andrew Pirondini committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    a1a264a View commit details
    Browse the repository at this point in the history
  4. fix(buttongroup): Fix bug preventing children from being disabled

    The fact that the ButtonGroup's disabled overrode the childrens meant
    that you couldn't individually disable the children. This updates it so
    you still can and adds a test case to verify it works.
    Andrew Pirondini committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    1dc8fa0 View commit details
    Browse the repository at this point in the history
  5. style(buttongroup): Fix glamorous import

    This removes the unnecessary additional line for destructuring glamorous
    to get Div.
    Andrew Pirondini committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    9f8493c View commit details
    Browse the repository at this point in the history