-
Notifications
You must be signed in to change notification settings - Fork 2
Commits on Mar 1, 2018
-
This adds a component for grouping Buttons together. It simply adds the correct borderRadius to any of it's children that are buttons and passes through the rest of the props. Along with this, the group can be disabled rather than having to disable all buttons individually.
Andrew Pirondini committedMar 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 87fc098 - Browse repository at this point
Copy the full SHA 87fc098View commit details -
Add
children
PropType validation and export ButtonGroupAndrew Pirondini committedMar 1, 2018 Configuration menu - View commit details
-
Copy full SHA for a3f7079 - Browse repository at this point
Copy the full SHA a3f7079View commit details -
Make
GroupedButton
component fit on one lineAndrew Pirondini committedMar 1, 2018 Configuration menu - View commit details
-
Copy full SHA for c81f839 - Browse repository at this point
Copy the full SHA c81f839View commit details -
Merge branch 'master' into add-buttongroup-component
Andrew Pirondini committedMar 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 0c2b0e6 - Browse repository at this point
Copy the full SHA 0c2b0e6View commit details -
style: Make GroupedButton on one line
There are still CI failures. Hopefully this actually fixes them.
Andrew Pirondini committedMar 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 323d8f5 - Browse repository at this point
Copy the full SHA 323d8f5View commit details -
test: Add missing ButtonGroup test
This adds new tests for the ButtonGroup with snapshots. It also pushes the latest version of the toolbox distribution since that got borked during merging.
Andrew Pirondini committedMar 1, 2018 Configuration menu - View commit details
-
Copy full SHA for a9a8478 - Browse repository at this point
Copy the full SHA a9a8478View commit details
Commits on Mar 6, 2018
-
fix(buttongroup): Fix disabled prop being overridden
The issue was that the disabled prop was being overridden by the more generic {...child.props}. To fix this I just had to reorder the props. Along with this I made several style changes suggested in CR.
Andrew Pirondini committedMar 6, 2018 Configuration menu - View commit details
-
Copy full SHA for a85c38b - Browse repository at this point
Copy the full SHA a85c38bView commit details -
fix(buttongroup): Remove borderRight from middle elements
This fixes the issue of having both the borderLeft of one button and the borderRight of the other button creating a border with twice the normal width. Instead, we remove the borderRight for all but the last button and use only the borderLefts to separate buttons.
Andrew Pirondini committedMar 6, 2018 Configuration menu - View commit details
-
Copy full SHA for c707efd - Browse repository at this point
Copy the full SHA c707efdView commit details -
test(buttongroup): Add test case for non-button children
This adds the test case for when a ButtonGroup has other children besides Button components. It should, in this case, not alter the other children as the updated shapshots show.
Andrew Pirondini committedMar 6, 2018 Configuration menu - View commit details
-
Copy full SHA for a1a264a - Browse repository at this point
Copy the full SHA a1a264aView commit details -
fix(buttongroup): Fix bug preventing children from being disabled
The fact that the ButtonGroup's disabled overrode the childrens meant that you couldn't individually disable the children. This updates it so you still can and adds a test case to verify it works.
Andrew Pirondini committedMar 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 1dc8fa0 - Browse repository at this point
Copy the full SHA 1dc8fa0View commit details -
style(buttongroup): Fix glamorous import
This removes the unnecessary additional line for destructuring glamorous to get Div.
Andrew Pirondini committedMar 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 9f8493c - Browse repository at this point
Copy the full SHA 9f8493cView commit details