Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --project to make yarn lint script work #7

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Add --project to make yarn lint script work #7

merged 1 commit into from
Feb 22, 2019

Conversation

chenesan
Copy link
Contributor

Purpose

Make yarn lint really works. Before this change tslint won't work because lack of --project parameter.

Change

  • Add --project in lint script

Risk

None.

Todo

None.

@chenesan chenesan self-assigned this Feb 22, 2019
@chenesan chenesan requested a review from hsunpei February 22, 2019 07:04
hsunpei
hsunpei approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@hsunpei hsunpei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this! 👍

@chenesan chenesan merged commit 7d8d978 into develop Feb 22, 2019
@chenesan chenesan mentioned this pull request Mar 18, 2019
Merged
@zhusee2 zhusee2 deleted the chore/make-yarn-lint-work branch September 9, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsunpei hsunpei hsunpei approved these changes

Assignees

@chenesan chenesan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenesan @hsunpei