Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert private field in root package.json #24

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Revert private field in root package.json #24

merged 2 commits into from
Mar 15, 2019

Conversation

chenesan
Copy link
Contributor

Purpose

Reset private: true on package.json, which is accidentally merged into develop in #21 and will cause yarn install failed.

Change

  • Reset private: true in root package.json.

Risk

None.

Todos

None.

@chenesan chenesan self-assigned this Mar 15, 2019
@chenesan chenesan requested review from zhusee2, hsunpei and tz5514 March 15, 2019 06:34
hsunpei
hsunpei approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@hsunpei hsunpei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenesan chenesan merged commit 55432bf into develop Mar 15, 2019
@chenesan chenesan mentioned this pull request Mar 18, 2019
Merged
@zhusee2 zhusee2 deleted the bugfix/revert-private-on-package-json branch September 9, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsunpei hsunpei hsunpei approved these changes

@zhusee2 zhusee2 zhusee2 approved these changes

@tz5514 tz5514 Awaiting requested review from tz5514

Assignees

@chenesan chenesan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenesan @zhusee2 @hsunpei