NC-462 Record which parts of date were specified by user #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpathania1
reviewed
Jan 23, 2018
timestring/Date.py
Outdated
| @@ -55,9 +55,39 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| class Specified: | |||
| def __init__(self, year, month, day, daytime, hour, minute, second, microsecond): | |||
| self.year = year | |||
There was a problem hiding this comment.
'year' means more actual year value. We can assign default values to all arguments so that it is clear that these are flags not values.
There was a problem hiding this comment.
I can add type hinting like year: Boolean. I think default values would be a bit confusing.
timestring/Date.py
Outdated
| self.year = year | ||
| self.month = month | ||
| self.day = day | ||
| self.daytime = daytime |
There was a problem hiding this comment.
is daytime not included in hour, min, sec? Do we need this separately?
There was a problem hiding this comment.
"9 o'clock" does not specify daytime -- am or pm is inferred but not explicit.
Set "specified" in Unix timestramp and plus_(). Separate parsing of am/pm from o'clock. Parse 11:11:11 am
dpathania1
approved these changes
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record what part of the time was specified by the user. This is needed for https://iamplus.atlassian.net/browse/AE-5159.
This solution uses output flags to describe the state of all components of a date and time reference (year, month, hour ,etc.) as either specified or not. This is similar to
parsedatetime.The specified fields are represented using a new class. This is convenient but takes space. Should we use a binary representation like
5=0000110to represent that just hour and minute were specified?Required for https://github.com/iAmPlus/aneeda/pull/1351