Validate CompressionLevel in BrotliStream ctor

Fix dotnet#46595
i3arnon · Aug 15, 2021 · a09b915 · a09b915
1 parent ec07ac8
commit a09b915
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/libraries/System.IO.Compression.Brotli/src/System/IO/Compression/BrotliUtils.cs b/src/libraries/System.IO.Compression.Brotli/src/System/IO/Compression/BrotliUtils.cs
@@ -9,7 +9,7 @@ internal static partial class BrotliUtils
         public const int WindowBits_Default = 22;
         public const int WindowBits_Max = 24;
         public const int Quality_Min = 0;
-        public const int Quality_Default = 11;
+        public const int Quality_Default = 6;
         public const int Quality_Max = 11;
         public const int MaxInputSize = int.MaxValue - 515; // 515 is the max compressed extra bytes
 

diff --git a/...aries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliStream.Compress.cs b/...aries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliStream.Compress.cs
@@ -23,6 +23,11 @@ public BrotliStream(Stream stream, CompressionLevel compressionLevel) : this(str
         /// <param name="leaveOpen"><see langword="true" /> to leave the stream open after disposing the <see cref="System.IO.Compression.BrotliStream" /> object; otherwise, <see langword="false" />.</param>
         public BrotliStream(Stream stream, CompressionLevel compressionLevel, bool leaveOpen) : this(stream, CompressionMode.Compress, leaveOpen)
         {
+            if ((int)compressionLevel is < BrotliUtils.Quality_Min or > BrotliUtils.Quality_Max)
+            {
+                throw new ArgumentException(SR.ArgumentOutOfRange_Enum, nameof(compressionLevel));
+            }
+
             _encoder.SetQuality(BrotliUtils.GetQualityFromCompressionLevel(compressionLevel));
         }