Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render all children regardless of type when using i18nIsDynamicList prop #1661

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

nicegamer7
Copy link
Contributor

Hi @adrai, this is followup to #1660. I noticed that rendering was still not working when using dynamic strings. This PR fixes that.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 96.167%. remained the same when pulling 0de7198 on nicegamer7:hotfix/children-type into b5efaa9 on i18next:master.

@adrai adrai merged commit c446896 into i18next:master Aug 10, 2023
@adrai
Copy link
Member

adrai commented Aug 10, 2023

v13.1.1

@siarheipashkevich
Copy link
Contributor

After upgrading to the latest version:
image

@adrai
Copy link
Member

adrai commented Aug 11, 2023

@siarheipashkevich Please provide a reproducible example repo.

@siarheipashkevich
Copy link
Contributor

I just upgraded my packages and try to start my build in web

@adrai
Copy link
Member

adrai commented Aug 11, 2023

Sorry, I'm not able to reproduce it here: https://github.com/i18next/react-i18next/tree/master/example/react

@siarheipashkevich
Copy link
Contributor

I use react-native and expo

@nicegamer7
Copy link
Contributor Author

@siarheipashkevich it looks like your browser is not expecting the optional chaining operator. If this only happens in development, I'd suggest making sure your browser is up to date. If this happens both in development and in production, I would suggest transpiling your code using something like Babel.

@siarheipashkevich
Copy link
Contributor

@nicegamer7 I use latest chrome version:
image

@siarheipashkevich
Copy link
Contributor

After downgrading to 13.0.3 everything works correctly

@siarheipashkevich
Copy link
Contributor

siarheipashkevich commented Aug 11, 2023

I think you should not to use optional chaining operator for supporting ES5

@adrai
Copy link
Member

adrai commented Aug 11, 2023

Does it work with 13.1.2 ?

@siarheipashkevich
Copy link
Contributor

Yes, it's work correctly right now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants