Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-848: Deep merge options.backend #849

Merged
merged 1 commit into from
Feb 22, 2021
Merged

fix-848: Deep merge options.backend #849

merged 1 commit into from
Feb 22, 2021

Conversation

felixmosh
Copy link
Contributor

Closes #848

isaachinman
isaachinman approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@isaachinman isaachinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this does seem sensible, I think we'll need to release it on a major, as it is a breaking change.

@felixmosh
Copy link
Contributor Author

Why is it a breaking change? pay attention to the order....
if the user do specify the loadPath, it will be the final value.
It just adds the loadPath & addPath if you didn't provide them.

(without them the app won't start)

@felixmosh
Copy link
Contributor Author

@isaachinman ping

@felixmosh
Copy link
Contributor Author

@isaachinman why this PR is not published as v7 major release?

@felixmosh
Copy link
Contributor Author

Ping?

@isaachinman
Copy link
Contributor

@felixmosh Do you want to change the target to the next-v10 branch and get this merged into the beta before release?

@felixmosh
Copy link
Contributor Author

@isaachinman sure, will do.

@isaachinman isaachinman changed the base branch from master to next-v10 February 22, 2021 10:40
@isaachinman isaachinman merged commit 0a4f144 into i18next:next-v10 Feb 22, 2021
@felixmosh felixmosh deleted the fix-848 branch February 22, 2021 11:28
isaachinman added a commit that referenced this pull request Feb 24, 2021
@isaachinman @franzmoro
@felixmosh @TKone7 @LeonardDrs
v8.0.0 (#965)
7c12340 
* Core changes to support NextJs v10

* Add default config file reading functionality

* Reimplement hoistNonReactStatics

* Update dependencies

* Strip out tests and unnecessary dependencies

* Fix linting setup

* Upgrade core dependencies

* Migrate config options to mirror NextJs

* v8.0.0-beta.0

* Remove deprecated config options and types

* Update example lockfile

* Remove need for locales and defaultLocale entirely

* Update example to use hooks

* Add documentation

* v8.0.0-beta.1

* Add NodeJs v14 to CircleCI

* Create serverSideTranslations.d.ts

* v8.0.0-beta.2

* fix: TS issues for v8-beta (#922)

* fix: export appWithTranslation type

also changed AppWithTranslation type: param is a React Component, not a React Component instance

* chore: remove unused NextI18Next exports

* fix: run-example prod script by adding the build step before it

* v8.0.0-beta.3

* fix: Remove server side code from client bundle (#926)

* Remove static dir entirely

* v8.0.0-beta.4

* feat: Add an ESM entry point to allow better bundle optimizations (#937)

* Add an ESM entry point to allow better tree-shaking & module concatenation

* Include ie11

* fix: added Trans to TS definition v8-beta (#951)

* added Trans to types

* fix: removed unused typess

* refactor: Use serialize-javascript (#954)

* refactor: Use NextJs i18n config API (#955)

* test: Add tests for config and consoleMessage (#956)

* test: Add coverage for createClient (#957)

* refactor: Update eslint config (#958)

* refactor: Update eslint config

* Fix lint

* test: Add e2e coverage via Cypress (#959)

* feat: Disable FS backend when user provides one (#930)

* feat: Disable FS backend when user provides one

* fixup! feat: Disable FS backend when user provides one

* fixup! feat: Disable FS backend when user provides one

* fixup! feat: Disable FS backend when user provides one

* test: Add test coverage to appWithTranslation and serverSideTranslations (#960)

* docs: Update README (#961)

* v8.0.0-beta.5

* docs: Update README (#962)

* v8.0.0-beta.6

* chore: Update example lockfile (#964)

* chore: Update example lockfile

* Update package.json

* fix: Deep merge options.backend, closes #848 (#849)

* fix: Make create-config defaultFile use localeStructure (#966)

use @cescoallegrini modifications from
#934

* Update README.md

Co-authored-by: Léonard Drouillas <leonard.drouillas@gmail.com>

* chore: Lint examples dir (#969)

* fix: Add server side loading of fallbackLng (#970)

* refactor: Remove i18next-http-backend (#971)

* refactor: Remove i18next-http-backend

* Update config.yml

* Update basic.e2e.ts

* refactor: Add react-i18next useSuspense (#973)

* docs: Update README (#975)

* refactor: Add typeof window check to createConfig (#976)

* refactor: Remove serialize-javascript and add configOverride to appWithTranslation (#972)

* refactor: Remove serialize-javascript and add configOverride to appWithTranslation

* Add serializeConfig option

* Add docs

* Update README.md

* docs: Update README (#977)

* Update peerDependencies and version

Co-authored-by: Francesco Moro <franzmoro@users.noreply.github.com>
Co-authored-by: Felix Mosheev <9304194+felixmosh@users.noreply.github.com>
Co-authored-by: Tobias Koller <34249734+TKone7@users.noreply.github.com>
Co-authored-by: Filipe Medeiros <filipesilvamedeiros@gmail.com>
Co-authored-by: Léonard Drouillas <leonard.drouillas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaachinman isaachinman isaachinman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

backend is not merged properly
2 participants
@felixmosh @isaachinman