-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pointer: map devices across all outputs by default #8352
Conversation
Mapping to all outputs by default only for pointer devices makes OpenTabletDriver's absolute mode (pointer device) and artist mode (tablet device) map differently despite otherwise identical internal mapping configurations. |
isnt that just #7586 |
Not exactly, this PR changes the default mapping for pointer devices only while #7586 only gives the option for tablet devices to map to all outputs. |
#7586 doesn't fix the problem since Hyprland/src/managers/PointerManager.cpp Line 682 in 88e9e03
|
I've changed it so that tablet, touch and pointer devices map across all outputs unless they are explicitly bound to an output. This changes how tablet regions are applied. When bound to an output, This fixes wlx-overlay-s whilst hopefully maintaining consistent behaviour between absolute mode and artist mode for tablets. I've done some brief testing with my tablet and it seems ok but I don't have a way to test touch devices. |
df6d5fd
to
a7637c2
Compare
a7637c2
to
72e883f
Compare
I've added an |
Just tested wlx-overlay-s with one of my monitors in negative space and the overlay pointer problem is back so need to figure out what's going on there... |
72e883f
to
b073bf3
Compare
Turns out it was an upstream issue galister/wlx-capture#3 so this is ready for review |
b073bf3
to
be87d0b
Compare
I've added the ability to set I could make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a reasonable compromise for now as pointer devices lack the configuration granularity that tablet devices have. Tablet tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wiki mr needed
oops conflict |
a91e607
to
6c434ed
Compare
clang-format missing xdddddd |
I don't think it's from my diff |
6c434ed
to
d2310d0
Compare
0.45 broke the stuff, prolly |
d2310d0
to
373248d
Compare
Rotated tablet works for me. In what way does it not work? |
further testing done with artist mode shows it is now working, however still being funky on osu!lazer. It seems to be stuck on the right side of the window. Looks to be a bug on hyprland considering the same config seems to work fine for me and others on sway. |
Describe your PR, what does it fix/add?
This fixes a problem with wlx-overlay-s where multi-monitor overlay pointer movement is broken. Somewhat related issues: #6023 #6889
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I'm not sure if it's correct to map across the entire space by default.
Is it ready for merging, or does it need work?
Ready