Fix: on-created-empty runs even if workspace is not created empty
#6026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5663
About the PR
This PR fixes the
on-created-emptyworkspace rule, which has unintentionally removed in 094bce8 (april 5th) and re-added back in #5452 (april 6th).The PR originally reused the same code as the original implementation (#3559), but changed to execute the command in
CWorkspace's constructor, as requested.However, when doing so no additional logic was added to guarantee that it would only execute commands when the workspace was, in fact, created empty.
The side-effect is that moving windows to new workspaces trigger the rule just the same.
About the implementation
The implementation tries not to revert the changes from
CWorkspace's constructor back tosanityCheckWorkspaces, and instead works within the new implementation to guarantee that the workspace is, in fact, being created empty by relying on the rule that created it to say so.