Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: require hyprwayland-scanner >= 0.3.5 #5943

Merged
merged 1 commit into from
May 8, 2024
Merged

meson: require hyprwayland-scanner >= 0.3.5 #5943

merged 1 commit into from
May 8, 2024

Conversation

rtgiskard
Copy link
Contributor

Describe your PR, what does it fix/add?

hyprwayland-scanner version has been bumped to 0.3.5, cmake build system is present, however the meson build system is not synced

I'm using arch, with AUR, it's default using the meson build system, which I prefer, however the previous installed hyprwayland-scanner from AUR is v0.3.4, and the latest version requirement is not synced in meson.build, it fails on build process without explicit prompt.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I think it's better to keep only one single build system, and meson is definitely a more modern and tidy build system for developers, maintain duplicate settings for two build system is unnecessary.

Is it ready for merging, or does it need work?

@fufexan
Copy link
Member

fufexan commented May 8, 2024

I think it's better to keep only one single build system, and meson is definitely a more modern and tidy build system for developers, maintain duplicate settings for two build system is unnecessary.

Feel free to try and convince vaxry to switch to meson only.

@fufexan fufexan merged commit 70b5e6d into hyprwm:main May 8, 2024
@vaxerski
Copy link
Member

vaxerski commented May 8, 2024

good luck with that. We're in the process of moving to cmake only.

@rtgiskard
Copy link
Contributor Author

good luck with that. We're in the process of moving to cmake only.

I know it's not proper to try to persuade others to use a specific tool, but I do want to emphasize the simplicity and efficiency of meson build system, it's really a very good thing worth to try for CPP.

Anyway, a single uniform build system is necessary, but before you're going to make the final decision, I sincerely hope you may have a glance at meson, and compare it yourself.

@rtgiskard
Copy link
Contributor Author

rtgiskard commented May 9, 2024

For myself, when it comes to choose the build system, the first and straightforward comparison is between CMakeLists.txt and meson.build, if I have to read one of the two files, I'd definite prefer meson.build, which is generally much less and clean, and I believe less is better.

From my experience, on writing meson.build, things are straightforward, you just need to declare things in a native manner. It's like coding to some degree, but as the author said, it's not Turing complete, you can't really code with meson, this helps to keep things simple and easy to understand.

It's really doing things good, uniform doc, and elegant solutions for various customization.

Just a share of personal experience, no means to underestimate cmake, it has been there for long time, there is mature and complete ecosystem, being widely used. Meson, on the other hand, is young and distinctive.

@vaxerski
Copy link
Member

vaxerski commented May 9, 2024

I've had both systems for over 2 years now under not only hyprland but other tools like hyprpaper or xdph and I have chosen cmake a while back for multiple reasons.

fwiw I hate writing meson

@rtgiskard
Copy link
Contributor Author

😂 Anyway, the build system is personal perspective, feel free to choose what you like.
Just to select a single one for a specific part to avoid unnecessary duplication of settings, which would generally lead to mess.

@vaxerski
Copy link
Member

vaxerski commented May 9, 2024

I agree, that's why we are moving off of meson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants