IJ assembly memory #1099
Open
IJ assembly memory #1099
+667
−862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…memory Conflicts: src/test/ij_assembly.c
rfalgout
reviewed
Feb 3, 2025
| @@ -511,6 +511,10 @@ HYPRE_SStructMatrixDestroy(HYPRE_SStructMatrix matrix); | |||
| HYPRE_Int | |||
| HYPRE_SStructMatrixInitialize(HYPRE_SStructMatrix matrix); | |||
|
|
|||
| HYPRE_Int | |||
| HYPRE_SStructMatrixSetEarlyAssembly( HYPRE_SStructMatrix matrix, | |||
There was a problem hiding this comment.
Here you use the name "Assembly" but in IJ you use "Assemble".
There was a problem hiding this comment.
Ah, they need to be consistent. Maybe both use "Assemble"?
There was a problem hiding this comment.
Either is fine with me, but maybe "Assemble" is better because it connects more explicitly to the assemble function.
rfalgout
approved these changes
Feb 3, 2025
victorapm
reviewed
Feb 4, 2025
| @@ -344,6 +344,15 @@ HYPRE_Int HYPRE_IJMatrixSetDiagOffdSizes(HYPRE_IJMatrix matrix, | |||
| HYPRE_Int HYPRE_IJMatrixSetMaxOffProcElmts(HYPRE_IJMatrix matrix, | |||
| HYPRE_Int max_off_proc_elmts); | |||
|
|
|||
| HYPRE_Int HYPRE_IJMatrixSetInitAllocation(HYPRE_IJMatrix matrix, | |||
There was a problem hiding this comment.
Should we document these functions in this PR?
victorapm
reviewed
Feb 4, 2025
| hypre_IJMatrixTranslator(matrix) = aux_matrix; | ||
| } | ||
| hypre_AuxParCSRMatrixInitAllocFactor(aux_matrix) = factor; | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #else | |
| HYPRE_UNUSED_VAR(matrix); | |
| HYPRE_UNUSED_VAR(factor); | |
| #endif |
victorapm
reviewed
Feb 4, 2025
| hypre_IJMatrixTranslator(matrix) = aux_matrix; | ||
| } | ||
| hypre_AuxParCSRMatrixEarlyAssemble(aux_matrix) = early_assemble; | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #else | |
| HYPRE_UNUSED_VAR(matrix); | |
| HYPRE_UNUSED_VAR(early_assemble); | |
| #endif |
victorapm
reviewed
Feb 4, 2025
| hypre_IJMatrixTranslator(matrix) = aux_matrix; | ||
| } | ||
| hypre_AuxParCSRMatrixGrowFactor(aux_matrix) = factor; | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #else | |
| HYPRE_UNUSED_VAR(matrix); | |
| HYPRE_UNUSED_VAR(factor); | |
| #endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds early assembly option to optimize the memory usage in the IJ interface to assemble matrices on GPUs.
User level APIs are