Refactor AutoGradingService as a real service #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
commented
Sep 23, 2024
| @@ -2,53 +2,65 @@ | |||
| from lms.models import AutoGradingConfig | |||
|
|
|||
|
|
|||
| def calculate_grade( | |||
There was a problem hiding this comment.
Moved to a method (instead of function)
| @@ -190,7 +196,3 @@ def views(self, pyramid_request): | |||
| @pytest.fixture | |||
| def get_page(self, patch): | |||
| return patch("lms.views.dashboard.api.user.get_page") | |||
|
|
|||
| @pytest.fixture | |||
| def calculate_grade(self, patch): | |||
There was a problem hiding this comment.
Using the service mock instead of a new function mock.
marcospri
force-pushed
the
refactor-auto-grading-service
branch
from
20c81e0
to
2761a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
Make this a real service in preparation to handle GradingSync objects and ideally making this PR a little bit smaller #6690