Skip to content

Commit

Permalink
Inline services only used on record_launch
Browse files Browse the repository at this point in the history
  • Loading branch information
marcospri committed Jul 26, 2023
1 parent ae49144 commit daefbce
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions lms/views/lti/basic_launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
from lms.product import Product
from lms.security import Permissions
from lms.services.assignment import AssignmentService
from lms.services.course import CourseService
from lms.services.grouping import GroupingService
from lms.validation import BasicLTILaunchSchema, ConfigureAssignmentSchema


Expand All @@ -35,9 +33,6 @@ def __init__(self, context, request):
self.assignment_service: AssignmentService = request.find_service(
name="assignment"
)
self.grouping_service: GroupingService = request.find_service(name="grouping")
self.course_service: CourseService = request.find_service(name="course")

self._guid = self.request.lti_params.get("tool_consumer_instance_guid")
self._resource_link_id = self.request.lti_params.get("resource_link_id")

Expand Down Expand Up @@ -163,10 +158,10 @@ def _show_document(self, assignment):
return {}

def _record_course(self):
course = self.course_service.get_from_launch(
course = self.request.find_service(name="course").get_from_launch(
self.request.product, self.request.lti_params
)
self.grouping_service.upsert_grouping_memberships(
self.request.find_service(name="grouping").upsert_grouping_memberships(
user=self.request.user, groups=[course]
)
return course
Expand All @@ -185,7 +180,6 @@ def _configure_assignment(self, assignment):
group_set_id=self.request.parsed_params.get("group_set"),
)


def _configure_js_for_file_picker(
self, route: str = "configure_assignment"
) -> dict:
Expand Down

0 comments on commit daefbce

Please sign in to comment.