Remove DefaultIfAny helper
#4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a cryptic piece of code that is no longer needed given the ability to specify default values for template arguments [1] [1] microsoft/TypeScript#45483
Codecov Report
@@ Coverage Diff @@
## master #4349 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 225 225
Lines 8576 8576
Branches 2031 2031
=======================================
Hits 8503 8503
Misses 73 73
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
robertknight
commented
Mar 24, 2022
| @@ -196,7 +186,7 @@ export function createStore(modules, initArgs = [], middleware = []) { | |||
| * @template State | |||
| * @template Actions | |||
| * @template {SelectorMap<State>} Selectors | |||
| * @template RootSelectors | |||
| * @template [RootSelectors={}] | |||
There was a problem hiding this comment.
The rootSelectors property of store modules is optional. In store modules without it, this treats it as if it were an empty object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a cryptic piece of code that is no longer needed given the ability to
specify default values for template arguments [1]
[1] microsoft/TypeScript#45483